Fix MusicXML export losing measure boundaries with chords#183
Merged
bmjcode merged 1 commit intofrescobaldi:masterfrom Apr 4, 2026
Merged
Conversation
Chords were not incrementing the bar duration counter, causing measure boundaries to be lost in MusicXML export. A 3-bar piece with chords would incorrectly export as 2 bars. Two functions affected: - new_chordbase(): explicit chord notation <c e g> - copy_prev_chord(): duration shorthand after chords (4 4) Added self.increase_bar_dura(duration) to both functions to match the behavior of regular notes. Fixes frescobaldi#171
Member
|
I've just realized there's this open PR. |
bmjcode
approved these changes
Apr 4, 2026
Collaborator
bmjcode
left a comment
bmjcode
left a comment
There was a problem hiding this comment.
Looks good to me. I confirmed this fixes the problem by importing the MusicXML into my old copy of Finale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chords were not incrementing the bar duration counter, causing measure boundaries to be lost in MusicXML export. A 3-bar piece with chords would incorrectly export as 2 bars.
Two functions affected:
Added self.increase_bar_dura(duration) to both functions to match the behavior of regular notes.
Fixes #171